Hi @ibilalkayy thanks for this. It looks like the documentation and dco checks are failing.

@tomponline It's my first time sending the PRs here and I don't know how to pass these checks. What is lacking?

@tomponline It's my first time sending the PRs here and I don't know how to pass these checks. What is lacking?

The DCO one says here;

https://github.com/lxc/lxd/actions/runs/5441251213/jobs/9895028225?pr=11914

What should I do to fix it ?
All proposed commits should include a Signed-off-by: line in their commit message.
This is most conveniently done by using --signoff (-s) when running git commit.

@tomponline Although I visited the contribution guide but I was not able to understand where to sign off these details.

Can you guide me? Thank you!

please can you rebase to fix the documentation failure.

@tomponline Although I visited the contribution guide but I was not able to understand where to sign off these details.

Can you guide me? Thank you!

Hi @ibilalkayy in this case as you just have one commit you can run git commit --amend then edit the commit message. Add a blank line after your original commit message, then add Signed-off-by: {your name} <{your email address}>.

If you run git log on the master branch you should be able to see examples of this. A convenient shortcut to sign commits automatically is the -s commit flag, which will sign commits with your name and email configured via git. For example, you could commit your changes with the following command git commit -sm "client: Adds a comment to the setupListener method."

@markylaing and @tomponline I added the signed-off details in the commit message and pushed it